Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Agora Video Calling, Cloud Recording and Replaying. #25

Merged
merged 25 commits into from
Nov 24, 2020
Merged

Added Agora Video Calling, Cloud Recording and Replaying. #25

merged 25 commits into from
Nov 24, 2020

Conversation

crimx
Copy link
Member

@crimx crimx commented Nov 20, 2020

  • Added TopBar UI.
  • Added RealtimePanel UI which is the togglable side panel on the right.
  • Added Rtc for managing Agora Electron SDK.
  • Added CloudRecording for managing Agora Cloud Recording RESTful API.
  • Added SmartPlayer for controlling Whiteboard Player and CombinePlayer consistently.
  • WhiteboardPage and Replay is refactored for better modularization and a couple of memory leak fixes.
  • A recordings field is added to the localStorage for saving recording records.

This PR is a proof of concept of integrating Agora Electron SDK and Cloud Recording into Flat-native. Currently only single user broadcasting is implemented. If approved, all following work will base on the code of this PR.
本 PR 打通了接入声网音视频录制回放的基础流程,目前仅实现了单人广播、云录制和回放。因修改涉及地方较多,先提交一次 PR 确认思路与方向无误。如确认通过,后续的音视频处理相关功能将基于本流程展开。

(I know this is a humongous PR 😂. Sorry bro. Integrating Agora is a tough work.)

@BlackHole1
Copy link
Collaborator

在代码中,如果有对象是后期不会去修改的,可使用: Object.freeze 来保证其安全。

能用 enum,则尽量用。

@BlackHole1 BlackHole1 merged commit 7f06358 into netless-io:master Nov 24, 2020
@crimx crimx deleted the top-bar branch January 8, 2021 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants