Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(i18n): add ClassroomPage #662

Merged
merged 1 commit into from
May 26, 2021
Merged

feat(i18n): add ClassroomPage #662

merged 1 commit into from
May 26, 2021

Conversation

Leooeloel
Copy link
Collaborator

No description provided.

@BlackHole1
Copy link
Collaborator

I feel that the names of many keys are not unique enough, do we need to introduce the concept of namespace. @Leooeloel @crimx

e.g:

i-know => i-know-extra-countdown

(namespace name)room-exit:
    i-know

@crimx crimx merged commit 9d3353f into netless-io:main May 26, 2021
@BlackHole1 BlackHole1 mentioned this pull request May 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crimx crimx crimx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Leooeloel @BlackHole1 @crimx