Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(main-app): add join room config to URLprotocol. #756

Merged
merged 1 commit into from
Jun 25, 2021
Merged

feat(main-app): add join room config to URLprotocol. #756

merged 1 commit into from
Jun 25, 2021

Conversation

Cheerego7
Copy link
Member

@Cheerego7 Cheerego7 commented Jun 22, 2021 •
edited
Loading

  • add logout methods to GlobalStore.
  • add Error Boundary component to APP Routes.
  • add launch app hooks, Listen to ipc for join room request, Jump to login page if user is not logged in.
  • refactor URLprotocol parameter in Join Page.
  • add join room methods in GitHubLogin, WeChatLogin.

hyrious
hyrious previously approved these changes Jun 22, 2021
View reviewed changes
@Cheerego7 Cheerego7 force-pushed the desktop-add-active-url-config branch from fdea112 to d83e583 Compare June 22, 2021 09:52
@BlackHole1
Copy link
Collaborator

WIP

@Cheerego7 Cheerego7 marked this pull request as draft June 23, 2021 05:45
@Cheerego7 Cheerego7 force-pushed the desktop-add-active-url-config branch 2 times, most recently from a400053 to 9d72e26 Compare June 24, 2021 10:22
@Cheerego7 Cheerego7 marked this pull request as ready for review June 24, 2021 11:24
@Cheerego7 Cheerego7 force-pushed the desktop-add-active-url-config branch from 9d72e26 to 49c62ca Compare June 25, 2021 02:10
@Cheerego7 Cheerego7 force-pushed the desktop-add-active-url-config branch from 49c62ca to ed0fc73 Compare June 25, 2021 05:28
@Cheerego7 Cheerego7 marked this pull request as draft June 25, 2021 05:52
@Cheerego7 Cheerego7 marked this pull request as ready for review June 25, 2021 05:53
@BlackHole1 BlackHole1 changed the base branch from main to url-protocol-join-room June 25, 2021 09:29
@BlackHole1 BlackHole1 merged commit 5ca1aa6 into netless-io:url-protocol-join-room Jun 25, 2021
BlackHole1 pushed a commit that referenced this pull request Jun 29, 2021
@Cheerego7 @BlackHole1
feat(main-app): add join room config to URLprotocol. (#756)
063df73
Leooeloel pushed a commit that referenced this pull request Jun 29, 2021
@BlackHole1 @Cheerego7
feat(URLProtocol): support browser launch flat join room (#772)
f9e4fa6 
* feat(main-app): add join room config to URLprotocol. (#756)

* fix(url-protocol): launch flat lost params in url protocol when system is macOS and first open (#767)

* feat(URLProtocol): listen to ipc event for launch flat app (#768)

* refactor(flat-components): forbid to refresh in Login page (#769)

* refactor(hook): improve useURLAppLauncher hook (#770)

don't request join room api when already in the same room

* fix(hook): join room logic error in useURLAppLauncher hook

after joining the room by repeatedly calling up Flat through the browser, if exit the room, will automatically join the room again.
because we have a problem in the logic of clearing the roomUUID

* refactor(hook): improve usePushHistory hook type

Co-authored-by: Cheerego7 <48879533+Cheerego7@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlackHole1 BlackHole1 BlackHole1 requested changes

@hyrious hyrious hyrious left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cheerego7 @BlackHole1 @hyrious