Add option to override timeouts for larger scans #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finholt
commented
Oct 30, 2020
plugin/pluginCore.js
Outdated
| try { | ||
| return await pa11y(htmlFilePath) | ||
| return await pa11y(htmlFilePath, {timeout, chromeLaunchConfig: {timeout}}) |
There was a problem hiding this comment.
Sets the timeout for both pa11y and puppeteer (chromeLaunchConfig). Both are 30 seconds by default, so only extending pa11y's just caused puppeteer to timeout instead
There was a problem hiding this comment.
The newer version of pa11y seems to have fixed this, so setting chromeLaunchConfig doesn't seem to be required anymore
Finholt
force-pushed
the
timeout-input
branch
from
384ef88
to
30e2db8
Compare
👷 Deploy request for netlify-plugin-a11y-demo pending review.Visit the deploys page to approve it
|
|
@jgerigmeyer reminded me that this PR existed, and it got a little outdated after 2 years 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to override pa11y's (and puppeteer's) default timeout
Sort of a stop-gap solution for the issue discussed in #5. Obviously, more parallel processing would be a better way to handle large sites, but this would at least allow medium-sized sites to bump up the timeout and still be able to scan everything