Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add publish step to release-please #70

Merged
merged 1 commit into from
Nov 9, 2023
Merged

fix: add publish step to release-please #70

merged 1 commit into from
Nov 9, 2023

Conversation

Skn0tt
Copy link
Contributor

@Skn0tt Skn0tt commented Nov 8, 2023

#69 got merged, but no NPM release was created. Probably because the release-please flow didn't include npm publish! This PR steals the release-please flow from https://github.com/netlify/edge-bundler, which hopefully works better.

@Skn0tt Skn0tt self-assigned this Nov 8, 2023
Copy link

netlify bot commented Nov 8, 2023

Deploy Preview for plugin-angular-universal-demo ready!

Name Link
🔨 Latest commit e19702e
🔍 Latest deploy log https://app.netlify.com/sites/plugin-angular-universal-demo/deploys/654b92d856249100088b787d
😎 Deploy Preview https://deploy-preview-70--plugin-angular-universal-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Nov 8, 2023
Copy link

@julienp julienp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Skn0tt Skn0tt merged commit 3b58f20 into main Nov 9, 2023
14 checks passed
@mrstork mrstork deleted the Skn0tt-patch-1 branch May 30, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants