Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copy temp file to prevent EXDEV: cross-device link not permitted #132

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

Skn0tt
Copy link
Contributor

@Skn0tt Skn0tt commented Jan 9, 2024

Some users are seeing this error:

[Netlify Blobs server] Error when writing data: [Error: EXDEV: cross-device link not permitted, rename '/tmp/netlify-blobsLCv61H/entries/7a7c9eec-3514-426a-bea9-3f7e7f659808/... -> '/run/media/.../site/.netlify/blobs-serves/entries/7a7c9eec-3514-426a-bea9-3f7e7f659808/...'] {
  errno: -18,
  code: 'EXDEV',
  syscall: 'rename',
  path: 'redacted',
  dest: 'redacted'
}

According to https://stackoverflow.com/questions/43206198/what-does-the-exdev-cross-device-link-not-permitted-error-mean, this happens when a file is renamed across two different partitions of a disk, which can definitely happen on dev machines we don't have control over. It mentions that a good fix is to copy & remove instead - that's what this PR does.

Resolves https://linear.app/netlify/issue/COM-227/reported-issue-using-blobs-from-netlify-dev.

@Skn0tt Skn0tt self-assigned this Jan 9, 2024
@Skn0tt Skn0tt requested a review from a team as a code owner January 9, 2024 13:14
Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for blobs-js ready!

Name Link
🔨 Latest commit 5c2fcda
🔍 Latest deploy log https://app.netlify.com/sites/blobs-js/deploys/659d46b3aeb9050008ee1da1
😎 Deploy Preview https://deploy-preview-132--blobs-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Jan 9, 2024
@Skn0tt Skn0tt merged commit 61b4ee6 into main Jan 9, 2024
10 of 15 checks passed
@Skn0tt Skn0tt deleted the fix-copy-file branch January 9, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants