feat(command-lm): add PATH configuration for fish shell #1943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lytedev it would be great if you can verify the changes in this PR |
erezrokah
added
the
type: feature
erezrokah
force-pushed
the
feat/lm_fish_shell
branch
from
61b131a
to
474148a
Compare
ehmicky
reviewed
Mar 1, 2021
src/utils/lm/install.js
Outdated
| ` | ||
| } | ||
|
|
||
| return `${CONTENT_COMMENT}if [ -f '${incFilePath}' ]; then source '${incFilePath}'; fi |
There was a problem hiding this comment.
I believe test -f ... && source might be sh-compatible? If so, we could use the same string for both shells.
This would also be more future-proof, since most Unix shells are sh-compatible.
ehmicky
approved these changes
Mar 1, 2021
erezrokah
force-pushed
the
feat/lm_fish_shell
branch
from
474148a
to
86b2e79
Compare
erezrokah
force-pushed
the
feat/lm_fish_shell
branch
from
86b2e79
to
c5a78ef
Compare
This was referenced Mar 16, 2021
Merged
Closed
This was referenced Mar 17, 2021
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Replaces netlify/netlify-lm-plugin#42
- Test plan
Existing tests are passing
- Description for the changelog
Add
fishshell support for Large Media install command- A picture of a cute animal (not mandatory but encouraged)
