fix(command-status): site info is missing for sites without netlify.toml #1999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
force-pushed
the
fix/status_missing_siteinfo
branch
from
3266fea
to
10c7e66
Compare
erezrokah
force-pushed
the
fix/status_missing_siteinfo
branch
from
10c7e66
to
0de2ba5
Compare
JGAntunes
approved these changes
Mar 16, 2021
This was referenced Mar 16, 2021
Merged
Closed
Closed
Closed
This was referenced Mar 18, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
I noticed
ntl statusonly prints the site information if the site has anetlify.toml.This doesn't make sense to me.
site.configPathis used later on in the code inlogJsonandprettyjson.render. Both filter outundefined.- Test plan
Run
ntl statuson a site withoutnetlify.toml- A picture of a cute animal (not mandatory but encouraged)
