Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate lm command #5975

Merged
merged 1 commit into from
Sep 1, 2023
Merged

chore: deprecate lm command #5975

merged 1 commit into from
Sep 1, 2023

Conversation

kaelig
Copy link
Member

@kaelig kaelig commented Sep 1, 2023

Summary

The Large Media feature was deprecated on September 1st, 2023 and will become unavailable in a future update. Learn more and discover alternative solutions

As a result, we'll hide the lm command from the CLI. It will keep working, but we recommend against setting up Large Media on new sites.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

kaeligd_in_the_style_of_an_epic_movie_poster_create_a_picture_o_b78a907e-b673-4017-953a-5ded10e61bf7 (1)

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

📊 Benchmark results

Comparing with 34e0faa

  • Dependency count: 1,331 (no change)
  • Package size: 295 MB ⬆️ 0.00% increase vs. 34e0faa

Copy link
Contributor

@sarahetter sarahetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kaelig kaelig merged commit 8441878 into main Sep 1, 2023
66 checks passed
@kaelig kaelig deleted the kaelig/hide-large-media branch September 1, 2023 17:55
@Skn0tt Skn0tt mentioned this pull request Sep 5, 2023
5 tasks
@Skn0tt
Copy link
Contributor

Skn0tt commented Sep 5, 2023

Hi! Could you please mark this as a fix: or feat:-commit next time? chore doesn't get listed in our changelog, and it feels like this PR warrants a changelog entry. I'll manually update the Github release when it's cut, so this is listed.

@kaelig
Copy link
Member Author

kaelig commented Sep 5, 2023

Absolutely — I didn't realize chores weren't surfaced in release notes!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants