Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace minimist on netlify-lambda.ts #6265

Merged

Conversation

hereje
Copy link
Contributor

@hereje hereje commented Dec 17, 2023

🎉 Thanks for submitting a pull request! 🎉

Summary

replace minimist with commander on netlify-lambda.ts

  • replace minimist
  • update code accordingly

Related to #3941


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

replace minimist with commander on netlify-lambda.ts

- replace minimist
- update code accordingly
@hereje hereje requested a review from a team as a code owner December 17, 2023 19:47
Copy link

github-actions bot commented Dec 17, 2023

📊 Benchmark results

Comparing with 00ea7f1

  • Dependency count: 1,399 (no change)
  • Package size: 405 MB (no change)
  • Number of ts-expect-error directives: 1,291 ⬇️ 0.08% decrease vs. 00ea7f1

@hereje
Copy link
Contributor Author

hereje commented Dec 17, 2023

After running

npm run build

and run test tests/unit/lib/functions/runtimes/js/builders/netlify-lambda.test.js

test works as expected.

@sarahetter
Copy link
Contributor

Hey, looks good! Can you please remove minimist from package.json in this PR as well?

@hereje
Copy link
Contributor Author

hereje commented Dec 18, 2023

Hey, looks good! Can you please remove minimist from package.json in this PR as well?

Sure!

@sarahetter sarahetter added the automerge Add to Kodiak auto merge queue label Dec 19, 2023
@kodiakhq kodiakhq bot merged commit a882392 into netlify:main Dec 19, 2023
34 checks passed
@hereje hereje deleted the refactor/replace_minimist/netlify-lambda.js branch December 19, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Add to Kodiak auto merge queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants