Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs for CRAL with netlify dev #30

Merged
merged 4 commits into from
Aug 1, 2019
Merged

update docs for CRAL with netlify dev #30

merged 4 commits into from
Aug 1, 2019

Conversation

swyxio
Copy link
Contributor

@swyxio swyxio commented Aug 1, 2019

for a while this readme was completely out of date with how we envision people would use CRA with netlify-lambda, in a Netlify Dev world. That is primarily because you no longer need netlify-lambda to locally serve Netlify Functions, nor do you need to configure CRA's setupProxy in order to use netlify-lambda in order to locally serve Netlify Functions. This is a good deal better.

So the reduced scope makes this reference repo almost irrelevant.

Almost.

There is still a usecase for netlify-lambda even with Netlify Dev, when you genuinely need to bundle/transform your Netlify Functions (e.g. for import/export syntax, or using TypeScript). That is now the purpose of this repo, to demonstrate how to use netlify-lambda as a Netlify Dev "function builder", in a create-react-app context (although this is now basically agnostic of whether you use create-react-app or vue-cli or @angular/cli etc.).

Yes this is non trivial churn. But we always want this repo to show the best practice, what we recommend people to do.

@biilmann
Copy link
Member

biilmann commented Aug 1, 2019

LGTM

@swyxio swyxio merged commit 278f3ce into master Aug 1, 2019
@swyxio swyxio deleted the documentNewCRAL branch August 1, 2019 19:47
@maiya-22
Copy link

Please see issue, re the readme is not updated. #68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants