Persist username from JWT or order #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraerino
force-pushed
the
feature/persist-username
branch
2 times, most recently
from
e5946f7
to
4602afb
Compare
In order to determine the user's name, the following fields are considered in this order: - UserMetadata["full_name"] from JWT claims - BillingAddress.Name from order - ShippingAddress.Name from order
mraerino
force-pushed
the
feature/persist-username
branch
from
4602afb
to
a2b9c45
Compare
|
Just to confirm, this will help solve our canonical user name question we had right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #120
- Summary
When a order is made while a user is logged in (JWT passed along) and it is their first order, a new user object will be created in gocommerce.
This PR introduces a new field for the user object:
nameIt will be set only on creation of the user.
In order to determine the user's name, the following fields are considered in this order:
UserMetadata["full_name"]from JWT claims (this is what the Identity Widget uses)BillingAddress.Namefrom orderShippingAddress.Namefrom order- Test plan
I created a test suite covering the creation of a user on their first order.
It also verifies the name field in the different cases.
- Description for the changelog
Persist user's name from JWT or order on their first order