New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(security) no token logging on claims parsing errors #265

Closed

yearofthedan wants to merge 1 commit into netlify:master from yearofthedan:master

yearofthedan commented Jan 7, 2021

This relates to #259

I've made the following changes:

No more token logging when the error is thrown
The original error message is included in the log instead (copied this pattern from elsewhere in the repo)

Cheers!


          fix(security) no token logging on claims parsing errors

5d6dddd

erezrokah added the type: bug label

erezrokah self-requested a review

January 7, 2021 10:36

This was referenced Jan 28, 2021

chore: add shared node config #278

Merged

fix(security): no token logging on claims parsing errors #279

Merged

Contributor

erezrokah commented Jan 28, 2021

Thanks @yearofthedan - sorry for the very late review.
I moved your fix to #279 and added a test case

erezrokah closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels