Fix CircleCI trigger #314
Merged
Fix CircleCI trigger #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraerino
added
the
type: chore
mraerino
force-pushed
the
fix/circle-trigger
branch
from
a5f513e
to
61e757c
Compare
mraerino
force-pushed
the
fix/circle-trigger
branch
from
0ca926d
to
5933dcf
Compare
This reverts commit 5933dcf.
bettse
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
The circle CI trigger used the wrong branch when running on trunk.
Also made sure we don't run this for forks.
- Test plan
Did some test runs for push and pull_request event types.
- Description for the changelog
n/a
- A picture of a cute animal (not mandatory but encouraged)