Fixes #855 Update Slate plugins to drop data arg #856
Conversation
| @@ -20,10 +21,9 @@ function changeHistory(change, type) { | |||
| */ | |||
| const next = historyOfType.first(); | |||
| const historyOfTypeIsValid = historyOfType.size > 1 | |||
| || next.length > 1 | |||
| || next[0].type !== 'set_selection'; | |||
| || ( next && next.length > 1 && next[0].type !== 'set_selection' ); | |||
There was a problem hiding this comment.
This changes the logic - should evaluate true if next.length > 1 OR next[0].type !== 'set_selection'. I also prefer multiline for readability. If there was no bug here, let's just remove the changes and leave as is.
There was a problem hiding this comment.
Oh I see, you're pulling the next check up - you can just prepend it:
const historyOfTypeIsValid = next && historyOfType.size > 1
(...)There was a problem hiding this comment.
I changed that because there was a bug, sometimes next is undefined.
But I don't understand this logic : next.length > 1 OR next[0].type.
It will throw an error if next.length === 0.
There was a problem hiding this comment.
I actually pulled this logic from Slate's core - we could make it safe by changing the last line to: || (next[0] && next[0].type !== 'set_selection');
|
Deploy preview ready! Built with commit 3a76293 |
|
Deploy preview ready! Built with commit 6901088 |
|
Deploy preview ready! Built with commit 6901088 |
erquhart
force-pushed
the
855_update_slate_plugin
branch
from
b9c7203
to
6901088
Compare
- Summary
Fixes #855 Update Slate plugins to drop data arg
- Test plan
cmd + zandcmd + yto undo and redo.cmd + ( b, i, s, u ).- Description for the changelog
cmd + u( but doesn't work either it throws an error ).