Skip to content

fix: prevent race condition in Stop method on gauge #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2022
Merged

fix: prevent race condition in Stop method on gauge #342

merged 1 commit into from
Jun 30, 2022

Conversation

mrdg
Copy link
Contributor

@mrdg mrdg commented Jun 29, 2022

This was causing some flakiness in the test suite of another service. Because wg.Add is called in a separate goroutine there's no guarantee that it gets called before users call Stop on the gauge.

@mrdg mrdg added the type: bug code to address defects in shipped code label Jun 29, 2022
@mrdg mrdg requested a review from a team as a code owner June 29, 2022 17:12
@mrdg mrdg changed the title bug: prevent race condition in Stop method on gauge fix: prevent race condition in Stop method on gauge Jun 29, 2022
@mrdg mrdg force-pushed the mrdg/gauge-race branch from f3b4857 to 50d36eb Compare June 29, 2022 17:15
@mrdg mrdg merged commit 7cc551e into main Jun 30, 2022
@mrdg mrdg deleted the mrdg/gauge-race branch June 30, 2022 08:41
@token-generator-app token-generator-app bot mentioned this pull request Jun 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rybit rybit rybit approved these changes

Assignees
No one assigned
Labels
type: bug code to address defects in shipped code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrdg @rybit