Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add renderToReadableStream example #50

Closed
wesbos opened this issue Feb 21, 2023 · 3 comments
Closed

Add renderToReadableStream example #50

wesbos opened this issue Feb 21, 2023 · 3 comments

Comments

@wesbos
Copy link

wesbos commented Feb 21, 2023

Would be nice to see the example using React 18's renderToReadableStream which is for Deno/Cloudflare/Edge environments

@nickytonline
Copy link
Contributor

Thanks for the feedback @wesbos!

The packages in this repository are being used in netlify/remix-template#83. I'll update the README here once that work is merged.

We were using the renderToReadableStream but replaced it in that PR. I think it's because the template is for a Node environment as well and edge environment and because of facebook/react#24226.

We use remix.init to provide the template for Netlify Functions and Edge Functions, so I'm going to test out renderToReadableStream over there again for edge.

@wesbos
Copy link
Author

wesbos commented Feb 21, 2023

AH gotcha. Working on it myself over here if anyone wants to reference. Not working yet though wesbos/awesome-uses#1534

@nickytonline
Copy link
Contributor

Going to go ahead and close this. Thanks for the repo share with an example Wes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants