Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1754 Add flow filter capability to filter on TCP flags #367

Merged

Conversation

msherif1234
Copy link
Contributor

@msherif1234 msherif1234 commented Jul 9, 2024

Description

using flow filter with TCP flags we can detect TCP syn flood

  • using ebpf standalone
    sudo TARGET_HOST=127.0.0.1 TARGET_PORT=9999 ./bin/netobserv-ebpf-agent ENABLE_FLOW_FILTER=true FILTER_TCP_FLAGS="SYN" FILTER_PROTOCOL="TCP"
  • use hping3 to simulate TCP syn flood
sudo hping3 -c 15000 -d 120 -S -w 64 -p 80 --flood --rand-source 192.168.1.159
HPING 192.168.1.159 (wlp0s20f3 192.168.1.159): S set, 40 headers + 120 data bytes
hping in flood mode, no replies will be shown
  • we can get large volume TCP flows with flags = 'SYN' back to back, from different srcIP to port 80 HTTP with identical length indicating TCP syn attack
ipv4: 13:01:09.909571 wlp0s20f3 IP 106.238.112.253:42985 > 192.168.1.159:80: dscp: 0x0 protocol:tcp type: 0 code: 0 dir:1 bytes:174 packets:1 flags:2 ends: 13:01:09.909571 dnsId: 0 dnsFlags: 0x0000 dnsLatency(ms): 0 rtt(ns) 0 DropPkts: 0 DropBytes: 0 DropCause 0
ipv4: 13:01:09.909861 wlp0s20f3 IP 98.111.71.240:43017 > 192.168.1.159:80: dscp: 0x0 protocol:tcp type: 0 code: 0 dir:1 bytes:174 packets:1 flags:2 ends: 13:01:09.909861 dnsId: 0 dnsFlags: 0x0000 dnsLatency(ms): 0 rtt(ns) 0 DropPkts: 0 DropBytes: 0 DropCause 0
ipv4: 13:01:09.950127 wlp0s20f3 IP 86.75.75.51:43336 > 192.168.1.159:80: dscp: 0x0 protocol:tcp type: 0 code: 0 dir:1 bytes:174 packets:1 flags:2 ends: 13:01:09.950127 dnsId: 0 dnsFlags: 0x0000 dnsLatency(ms): 0 rtt(ns) 0 DropPkts: 0 DropBytes: 0 DropCause 0
ipv4: 13:01:10.226393 wlp0s20f3 IP 181.231.154.198:45517 > 192.168.1.159:80: dscp: 0x0 protocol:tcp type: 0 code: 0 dir:1 bytes:174 packets:1 flags:2 ends: 13:01:10.226393 dnsId: 0 dnsFlags: 0x0000 dnsLatency(ms): 0 rtt(ns) 0 DropPkts: 0 DropBytes: 0 DropCause 0
ipv4: 13:01:09.711814 wlp0s20f3 IP 94.238.144.182:41158 > 192.168.1.159:80: dscp: 0x0 protocol:tcp type: 0 code: 0 dir:1 bytes:174 packets:1 flags:2 ends: 13:01:09.711814 dnsId: 0 dnsFlags: 0x0000 dnsLatency(ms): 0 rtt(ns) 0 DropPkts: 0 DropBytes: 0 DropCause 0
ipv4: 13:01:09.731651 wlp0s20f3 IP 74.23.143.115:41392 > 192.168.1.159:80: dscp: 0x0 protocol:tcp type: 0 code: 0 dir:1 bytes:174 packets:1 flags:2 ends: 13:01:09.731651 dnsId: 0 dnsFlags: 0x0000 dnsLatency(ms): 0 rtt(ns) 0 DropPkts: 0 DropBytes: 0 DropCause 0

image

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 4.16667% with 23 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@7138dc8). Learn more about missing BASE report.
Report is 9 commits behind head on main.

Files Patch % Lines
pkg/ebpf/flow_filter.go 4.34% 22 Missing ⚠️
pkg/agent/agent.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #367   +/-   ##
=======================================
  Coverage        ?   32.51%           
=======================================
  Files           ?       48           
  Lines           ?     3629           
  Branches        ?        0           
=======================================
  Hits            ?     1180           
  Misses          ?     2348           
  Partials        ?      101           
Flag Coverage Δ
unittests 32.51% <4.16%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/agent/config.go 10.00% <ø> (ø)
pkg/ebpf/bpf_x86_bpfel.go 0.00% <ø> (ø)
pkg/ebpf/tracer.go 0.00% <ø> (ø)
pkg/agent/agent.go 35.85% <0.00%> (ø)
pkg/ebpf/flow_filter.go 37.58% <4.34%> (ø)

@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 9, 2024
Copy link

github-actions bot commented Jul 9, 2024

New image:
quay.io/netobserv/netobserv-ebpf-agent:e714b5a

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=e714b5a make set-agent-image

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 9, 2024
@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 10, 2024
Copy link

New image:
quay.io/netobserv/netobserv-ebpf-agent:6e859c2

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=6e859c2 make set-agent-image

Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpinsonneau jpinsonneau changed the title Add flow filter capability to filter on TCP flags NETOBSERV-1754 Add flow filter capability to filter on TCP flags Jul 11, 2024
Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Jul 14, 2024
@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 14, 2024
@openshift-ci openshift-ci bot added the lgtm label Jul 19, 2024
@msherif1234
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jul 23, 2024
Copy link

New image:
quay.io/netobserv/netobserv-ebpf-agent:20f17d0

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=20f17d0 make set-agent-image

@msherif1234
Copy link
Contributor Author

/approve

Copy link

openshift-ci bot commented Aug 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 7b7dc40 into netobserv:main Aug 6, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants