Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add config setting for not sending additional properties for Li… #103

Merged
merged 2 commits into from
May 12, 2023

Conversation

cbaker6
Copy link
Member

@cbaker6 cbaker6 commented May 12, 2023

…veQuery connections

New Pull Request Checklist

Issue Description

Parse Server < 4.0.0 can't handle certain types of properties during LiveQuery connection #102

Approach

Provide a SDK config property, liveQueryConnectionAdditionalProperties that can be set to false to work with old servers. e.g:

try await ParseSwift.initialize(applicationId: "applicationId",
                                         clientKey: "clientKey",
                                         primaryKey: "primaryKey",
                                         serverURL: url,
                                         liveQueryConnectionAdditionalProperties: false)

TODOs before merging

  • Add tests
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #103 (b88f2dc) into main (4238f91) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
- Coverage   91.63%   91.61%   -0.03%     
==========================================
  Files         172      172              
  Lines       15385    15402      +17     
==========================================
+ Hits        14098    14110      +12     
- Misses       1287     1292       +5     
Impacted Files Coverage Δ
Sources/ParseSwift/LiveQuery/LiveQuerySocket.swift 63.06% <100.00%> (+0.67%) ⬆️
Sources/ParseSwift/LiveQuery/Messages.swift 100.00% <100.00%> (ø)
Sources/ParseSwift/Parse.swift 97.19% <100.00%> (+0.02%) ⬆️
Sources/ParseSwift/Types/ParseConfiguration.swift 98.03% <100.00%> (+0.08%) ⬆️

... and 1 file with indirect coverage changes

@cbaker6 cbaker6 merged commit 0902da8 into main May 12, 2023
@cbaker6 cbaker6 deleted the liveQuery branch May 12, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant