Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove all generic shadow warnings #120

Merged
merged 1 commit into from
Jun 20, 2023
Merged

fix: remove all generic shadow warnings #120

merged 1 commit into from
Jun 20, 2023

Conversation

cbaker6
Copy link
Member

@cbaker6 cbaker6 commented Jun 20, 2023

New Pull Request Checklist

Issue Description

Compiling the project in Swift 5.9 shows there's a number of generic shadows in the code.

Approach

Remove all shadowing of generic types.

TODOs before merging

  • Add tests
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #120 (a997f31) into main (e92241c) will increase coverage by 0.06%.
The diff coverage is 80.76%.

@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
+ Coverage   91.55%   91.62%   +0.06%     
==========================================
  Files         173      173              
  Lines       15425    15425              
==========================================
+ Hits        14123    14133      +10     
+ Misses       1302     1292      -10     
Impacted Files Coverage Δ
...rces/ParseSwift/LiveQuery/LiveQueryConstants.swift 50.00% <0.00%> (ø)
Sources/ParseSwift/Types/ParseServer+async.swift 100.00% <ø> (ø)
Sources/ParseSwift/Types/ParseServer+combine.swift 95.83% <ø> (ø)
Sources/ParseSwift/LiveQuery/ParseLiveQuery.swift 70.84% <33.33%> (ø)
Sources/ParseSwift/API/API+Command.swift 88.08% <100.00%> (ø)
...urces/ParseSwift/API/API+NonParseBodyCommand.swift 80.00% <100.00%> (ø)
Sources/ParseSwift/Types/Query.swift 90.67% <100.00%> (ø)

... and 2 files with indirect coverage changes

@cbaker6 cbaker6 merged commit 424ebff into main Jun 20, 2023
25 of 26 checks passed
@cbaker6 cbaker6 deleted the docInfoNits branch June 20, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant