Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: query findAll() throwing hang risk warning #14

Merged
merged 1 commit into from
Nov 7, 2022
Merged

fix: query findAll() throwing hang risk warning #14

merged 1 commit into from
Nov 7, 2022

Conversation

cbaker6
Copy link
Member

@cbaker6 cbaker6 commented Nov 7, 2022

New Pull Request Checklist

Issue Description

findAll on older versions of Swift needed to run synchronously to fetch results. This causes newer versions of Xcode to throw warnings.

Close #13

Approach

Use async/await on newer versions of Swift for findAll()

TODOs before merging

  • Add tests
  • Add entry to changelog

@codecov-commenter
Copy link

Codecov Report

Merging #14 (049876a) into main (4a52629) will decrease coverage by 0.23%.
The diff coverage is 90.69%.

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
- Coverage   87.90%   87.66%   -0.24%     
==========================================
  Files         279      161     -118     
  Lines       68622    16347   -52275     
==========================================
- Hits        60323    14331   -45992     
+ Misses       8299     2016    -6283     
Impacted Files Coverage Δ
Sources/ParseSwift/Types/Query.swift 88.05% <90.69%> (+0.34%) ⬆️
Sources/ParseSwift/Storage/ParseFileManager.swift 86.15% <0.00%> (-6.67%) ⬇️
...ources/ParseSwift/Storage/ParseKeyValueStore.swift 91.66% <0.00%> (-5.56%) ⬇️
Sources/ParseSwift/Types/ParseAnalytics.swift 90.74% <0.00%> (-1.45%) ⬇️
Sources/ParseSwift/Storage/KeychainStore.swift 95.44% <0.00%> (-1.14%) ⬇️
Sources/ParseSwift/Parse.swift 98.38% <0.00%> (-0.81%) ⬇️
Sources/ParseSwift/Coding/AnyEncodable.swift 62.29% <0.00%> (-0.55%) ⬇️
Sources/ParseSwift/Objects/ParseInstallation.swift 74.27% <0.00%> (-0.17%) ⬇️
Sources/ParseSwift/Objects/ParseUser.swift 77.55% <0.00%> (-0.08%) ⬇️
...rces/ParseSwift/Types/ParseAnalytics+combine.swift 100.00% <0.00%> (ø)
... and 122 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cbaker6 cbaker6 merged commit 57de231 into main Nov 7, 2022
@cbaker6 cbaker6 deleted the findAll branch November 7, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thread running at QOS_CLASS_USER_INITIATED when using findAll()
2 participants