Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Encode id and className properties for nested non-ParseObjects #177

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

cbaker6
Copy link
Member

@cbaker6 cbaker6 commented Jul 13, 2024

New Pull Request Checklist

Issue Description

Close #140

Approach

Since id and className are computed properties, they are not encoded by default and therefore can be removed from the ParseEncoder SkipKeys enum. Note that these keys should not be encoded manually if a developer decides to add their own custom encoding for ParseObjects or else the server may not handle their objects properly.

TODOs before merging

  • Add tests
  • Add entry to changelog

@cbaker6 cbaker6 linked an issue Jul 13, 2024 that may be closed by this pull request
3 tasks
Copy link

codecov bot commented Jul 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.28%. Comparing base (173e7d8) to head (0d65c80).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
- Coverage   91.31%   91.28%   -0.04%     
==========================================
  Files         178      178              
  Lines       12073    12075       +2     
==========================================
- Hits        11025    11023       -2     
- Misses       1048     1052       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbaker6 cbaker6 merged commit f13ad6b into main Jul 13, 2024
14 checks passed
@cbaker6 cbaker6 deleted the encodeSkipKeys branch July 13, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fields named "id" are skipped in nested objects
1 participant