Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for hook triggers on ParseConfig #179

Merged
merged 6 commits into from
Jul 20, 2024
Merged

Conversation

cbaker6
Copy link
Member

@cbaker6 cbaker6 commented Jul 20, 2024

New Pull Request Checklist

Issue Description

The Parse Server added support for hook triggers in CloudCode for ParseConfig in parse-community/parse-server#9232.

Approach

  • Add first class support in ParseSwift, the SDK currently already supports it using its default initializer, but the developer can easily make mistakes
  • Bump minimum requirements to Swift 5.7 and Xcode 14.2. Note most Swift packages have a minimum of Swift 5.8

TODOs before merging

  • Add tests
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

Copy link

codecov bot commented Jul 20, 2024

Codecov Report

Attention: Patch coverage is 99.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.35%. Comparing base (1199b57) to head (6a6e3ff).

Files Patch % Lines
...es/ParseSwift/Protocols/ParseHookTriggerable.swift 98.86% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
+ Coverage   91.28%   91.35%   +0.07%     
==========================================
  Files         178      179       +1     
  Lines       12075    12162      +87     
==========================================
+ Hits        11023    11111      +88     
+ Misses       1052     1051       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbaker6 cbaker6 merged commit d57b7c9 into main Jul 20, 2024
14 checks passed
@cbaker6 cbaker6 deleted the triggerConfig branch July 20, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant