Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve ParseVersion and SDK Initialization #49

Merged
merged 30 commits into from
Jan 18, 2023
Merged

feat: Improve ParseVersion and SDK Initialization #49

merged 30 commits into from
Jan 18, 2023

Conversation

cbaker6
Copy link
Member

@cbaker6 cbaker6 commented Jan 18, 2023

New Pull Request Checklist

Issue Description

  • ParseVersion doesn't support pre-release versions of the SDK
  • Initializing the SDK currently suppresses errors if they occur instead of throwing

Approach

  • Make the SDK handle and compare prerelease versions to each other and actual releases. This will be useful when migrations are required between updates
  • Initializing the SDK now throws. Errors can be handled with try or ignored with try?

TODOs before merging

  • Add tests
  • Add entry to changelog

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #49 (62739e6) into main (1e2d713) will decrease coverage by 2.54%.
The diff coverage is 98.34%.

@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
- Coverage   90.33%   87.80%   -2.54%     
==========================================
  Files         163      163              
  Lines       16361    16479     +118     
==========================================
- Hits        14780    14469     -311     
- Misses       1581     2010     +429     
Impacted Files Coverage Δ
Sources/ParseSwift/Types/QueryWhere.swift 100.00% <ø> (ø)
Sources/ParseSwift/Types/ParseVersion.swift 97.73% <98.22%> (+1.65%) ⬆️
Sources/ParseSwift/Parse.swift 98.93% <100.00%> (+0.01%) ⬆️
Sources/ParseSwift/Objects/ParseObject.swift 74.83% <0.00%> (-15.80%) ⬇️
Sources/ParseSwift/Objects/ParseInstallation.swift 74.19% <0.00%> (-11.93%) ⬇️
Sources/ParseSwift/Objects/ParseUser.swift 78.00% <0.00%> (-10.23%) ⬇️
Sources/ParseSwift/Types/Query.swift 88.25% <0.00%> (-0.31%) ⬇️
...urces/ParseSwift/API/ParseURLSessionDelegate.swift 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cbaker6 cbaker6 changed the title feat: Improve ParseVersion feat: Improve ParseVersion and SDK Initialization Jan 18, 2023
@cbaker6 cbaker6 merged commit c7c83f1 into main Jan 18, 2023
@cbaker6 cbaker6 deleted the threading branch January 18, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant