Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add option to connect to a specific server #50

Merged
merged 5 commits into from
Jan 20, 2023
Merged

feat: Add option to connect to a specific server #50

merged 5 commits into from
Jan 20, 2023

Conversation

cbaker6
Copy link
Member

@cbaker6 cbaker6 commented Jan 20, 2023

New Pull Request Checklist

Issue Description

The SDK currently doesn't allow the ability to connect to a different Parse Server than the one configured during initialization. This can make it hard to use the Swift SDK for Cloud Code in a multi-server environment.

Approach

Add the option to allow the developer to specify the URL for a specific call. If the URL string provided can't be turned into a real URL, default to the configured URL. This allows Swift Cloud Code to replicate directAccess by making all calls to the same server to complete a particular ParseHook or ParseTrigger.

TODOs before merging

  • Add tests
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Merging #50 (7b81604) into main (c7c83f1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #50   +/-   ##
=======================================
  Coverage   90.43%   90.44%           
=======================================
  Files         163      163           
  Lines       16482    16492   +10     
=======================================
+ Hits        14906    14916   +10     
  Misses       1576     1576           
Impacted Files Coverage Δ
Sources/ParseSwift/API/API+Command.swift 89.90% <100.00%> (ø)
...urces/ParseSwift/API/API+NonParseBodyCommand.swift 82.14% <100.00%> (ø)
Sources/ParseSwift/API/API.swift 99.39% <100.00%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cbaker6 cbaker6 merged commit 6cca2ff into main Jan 20, 2023
@cbaker6 cbaker6 deleted the optionURL branch January 20, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant