Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add missing become() type methods #66

Merged
merged 1 commit into from
Mar 10, 2023
Merged

feat: Add missing become() type methods #66

merged 1 commit into from
Mar 10, 2023

Conversation

cbaker6
Copy link
Member

@cbaker6 cbaker6 commented Mar 10, 2023

New Pull Request Checklist

Issue Description

The become() type method is currently not available to use for async/await and Combine.

Approach

Add the missing methods and have them call their completion handler counterpart.

TODOs before merging

  • Add tests
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #66 (f5b8650) into main (ed55608) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #66   +/-   ##
=======================================
  Coverage   90.45%   90.46%           
=======================================
  Files         166      166           
  Lines       14942    14952   +10     
=======================================
+ Hits        13516    13526   +10     
  Misses       1426     1426           
Impacted Files Coverage Δ
Sources/ParseSwift/Objects/ParseUser+async.swift 94.23% <100.00%> (+0.12%) ⬆️
Sources/ParseSwift/Objects/ParseUser+combine.swift 95.86% <100.00%> (+0.14%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cbaker6 cbaker6 merged commit 62eee27 into main Mar 10, 2023
@cbaker6 cbaker6 deleted the becomeType branch March 10, 2023 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant