Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: saving nested ParseObjects and ParseFiles #8

Merged
merged 2 commits into from
Oct 23, 2022
Merged

fix: saving nested ParseObjects and ParseFiles #8

merged 2 commits into from
Oct 23, 2022

Conversation

cbaker6
Copy link
Member

@cbaker6 cbaker6 commented Oct 23, 2022

New Pull Request Checklist

Issue Description

Deep saving ParseFile's and in some cases, ParseObject's do not save correctly.

Approach

The nested ParseObject's and ParseFile's are saving to the server correctly, but the nested objects aren't being used properly when deep saving. Pass the saved child objects back to the parent object when deep saving.

TODOs before merging

  • Add tests
  • Add entry to changelog

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2022

Codecov Report

Merging #8 (630c371) into main (8c58ad2) will increase coverage by 0.01%.
The diff coverage is 96.55%.

@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   90.37%   90.38%   +0.01%     
==========================================
  Files         161      161              
  Lines       16319    16335      +16     
==========================================
+ Hits        14748    14765      +17     
+ Misses       1571     1570       -1     
Impacted Files Coverage Δ
Sources/ParseSwift/Coding/ParseEncoder.swift 78.14% <83.33%> (ø)
...urces/ParseSwift/API/API+NonParseBodyCommand.swift 81.92% <100.00%> (+0.33%) ⬆️
Sources/ParseSwift/Objects/ParseObject+async.swift 96.66% <100.00%> (+0.07%) ⬆️
Sources/ParseSwift/Objects/ParseObject.swift 90.18% <100.00%> (+0.06%) ⬆️
Sources/ParseSwift/Protocols/Objectable.swift 92.30% <100.00%> (+0.20%) ⬆️
Sources/ParseSwift/Objects/ParseUser+async.swift 93.52% <0.00%> (+0.40%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cbaker6
Copy link
Member Author

cbaker6 commented Oct 23, 2022

@bcbeta this should fix the issue you were having with ParseFile.

@cbaker6 cbaker6 merged commit da11b81 into main Oct 23, 2022
@cbaker6 cbaker6 deleted the fixFiles branch October 23, 2022 22:34
@bcbeta
Copy link

bcbeta commented Oct 27, 2022

Yes this fixed it! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants