fix: All object endpoints need to be public #80
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
Currently
ParseUser.become()
andParseUser.linkCommand
are broken due to changes with theendpoint
creating in #62. This is due the changes in 62 that made theendpoint
computed property required for allParseObject
's, but the endpoints for specializedParseObject
's likeParseUser
,ParseInstallation
had theirendpoints
internal to the SDK, resulting in the defaultendpoint
in theObjectable
protocol to be used outside of testing and by any developer. This causes some features not to work.Approach
Make all
endpoint
's public to replace the default implementation inObjectable
.Added the tests below to ensure public access to the endpoints remain. Note that the SDK isn't
@testable
on purpose:Parse-Swift/Tests/ParseSwiftTests/ObjectEndpointTests.swift
Lines 11 to 123 in 6e81c2f
TODOs before merging