Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Release cocoapods #82

Merged
merged 3 commits into from
Mar 16, 2023
Merged

fix: Release cocoapods #82

merged 3 commits into from
Mar 16, 2023

Conversation

cbaker6
Copy link
Member

@cbaker6 cbaker6 commented Mar 16, 2023 •
edited
Loading

New Pull Request Checklist

Issue Description

Approach

TODOs before merging

  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 16, 2023
View reviewed changes
ParseSwiftOG.podspec
@@ -1,23 +1,23 @@
Pod::Spec.new do |s|
s.name = "ParseSwift"
s.version = "1.0.0"
s.name = "ParseSwiftOG"

Check warning

Code scanning / Rubocop (reported by Codacy)

Checks if uses of quotes match the configured preference.

Prefer single-quoted strings when you don't need string interpolation or special symbols.
ParseSwiftOG.podspec
s.name = "ParseSwift"
s.version = "1.0.0"
s.name = "ParseSwiftOG"
s.version = "5.3.0"

Check warning

Code scanning / Rubocop (reported by Codacy)

Checks if uses of quotes match the configured preference.

Prefer single-quoted strings when you don't need string interpolation or special symbols.
@codecov
Copy link

codecov bot commented Mar 16, 2023 •
edited
Loading

Codecov Report

Merging #82 (9f35bd9) into main (6e81c2f) will decrease coverage by 2.91%.
The diff coverage is 66.66%.

❗ Current head 9f35bd9 differs from pull request most recent head 1d7b252. Consider uploading reports for the commit 1d7b252 to get more accurate results

@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
- Coverage   90.56%   87.65%   -2.91%     
==========================================
  Files         169      128      -41     
  Lines       15098    12493    -2605     
==========================================
- Hits        13673    10951    -2722     
- Misses       1425     1542     +117
Impacted Files Coverage Δ
Sources/ParseSwift/Types/ParseFile.swift 56.79% <0.00%> (-39.33%) ⬇️
Sources/ParseSwift/Extensions/URLSession.swift 64.16% <100.00%> (-19.17%) ⬇️

... and 62 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cbaker6 cbaker6 linked an issue Mar 16, 2023 that may be closed by this pull request
ParseSwift.podspec s.version 1.0.0 #81
Closed
3 tasks
@cbaker6 cbaker6 merged commit 4eb872d into main Mar 16, 2023
@cbaker6 cbaker6 deleted the pods branch March 16, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ParseSwift.podspec s.version 1.0.0
1 participant
@cbaker6