fix: ParseFile id creation should be consistent to ensure proper hashing #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -17,7 +17,7 @@ | |||
| func prepareURLRequest(options: API.Options, | |||
| batching: Bool = false, | |||
| childObjects: [String: PointerType]? = nil, | |||
| childFiles: [UUID: ParseFile]? = nil) async -> Result<URLRequest, ParseError> { | |||
| childFiles: [String: ParseFile]? = nil) async -> Result<URLRequest, ParseError> { | |||
Check warning
Code scanning / Tailor (reported by Codacy)
Function should have at least one blank line after it
Codecov Report
@@ Coverage Diff @@
## main #83 +/- ##
==========================================
- Coverage 90.55% 87.55% -3.00%
==========================================
Files 169 128 -41
Lines 15098 12514 -2584
==========================================
- Hits 13672 10957 -2715
- Misses 1426 1557 +131
... and 58 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
ParseFilegeneration ofidis not constant, which could produce multiple file saves.ParseFilealso isn'tIdentifiablerequiring extra work to use in SwiftUI.Approach
idgeneration of aParseFileconsistent so when the developer attempts to save multiple versions of the same file, the file is only saved once and replaced for other instances to reduce network callsParseFileIdentifiableTODOs before merging