fix: Prevent crash when the SDK has not been initialized #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov Report
@@ Coverage Diff @@
## main #95 +/- ##
==========================================
+ Coverage 91.42% 91.46% +0.03%
==========================================
Files 172 172
Lines 15261 15295 +34
==========================================
+ Hits 13953 13990 +37
+ Misses 1308 1305 -3
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -88,11 +90,22 @@ | |||
| } | |||
| } | |||
|
|
|||
| /// Specifies if a `ParseObject` has been saved. | |||
| public func isSaved() async throws -> Bool { | |||
Check warning
Code scanning / Tailor (reported by Codacy)
Function should have at least one blank line after it
| func toPointer() throws -> PointerType { | ||
| return try PointerType(self) | ||
| } | ||
|
|
||
| func endpoint(_ method: API.Method) -> API.Endpoint { | ||
| func endpoint(_ method: API.Method) async throws -> API.Endpoint { |
Check warning
Code scanning / Tailor (reported by Codacy)
Function should have at least one blank line after it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
The SDK can crash if the developer makes a call that requires a ParseSwift config parameter, but hasn't properly configured the SDK.
Approach
Suspend all method calls that access the SDK config parameters until the SDK is initialized or throw an error after the default time limit (current 5 seconds) if the suspend time is exceeded.
TODOs before merging