Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Make some ParseObject methods required #96

Merged
merged 5 commits into from
May 2, 2023
Merged

Conversation

cbaker6
Copy link
Member

@cbaker6 cbaker6 commented May 2, 2023

New Pull Request Checklist

Issue Description

Certain methods like: init(objectId: String), hasSameObjectId(), toPointer(), endpoint(), and isSaved() are not required in the ParseObject protocol, preventing the SDK from taking advantage of developer implementations.

Approach

Add the aforementioned methods as required and preserve their default implementations.

TODOs before merging

  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #96 (36cfaa2) into main (a746db0) will decrease coverage by 0.01%.
The diff coverage is 94.28%.

@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
- Coverage   91.46%   91.46%   -0.01%     
==========================================
  Files         172      172              
  Lines       15295    15240      -55     
==========================================
- Hits        13990    13939      -51     
+ Misses       1305     1301       -4     
Impacted Files Coverage Δ
...urces/ParseSwift/API/API+NonParseBodyCommand.swift 80.00% <ø> (ø)
Sources/ParseSwift/API/API.swift 99.41% <ø> (ø)
Sources/ParseSwift/API/Responses.swift 95.00% <ø> (ø)
Sources/ParseSwift/Protocols/ParseTypeable.swift 90.90% <ø> (+35.35%) ⬆️
Sources/ParseSwift/Protocols/Objectable.swift 91.66% <92.00%> (-6.30%) ⬇️
Sources/ParseSwift/Objects/ParseObject.swift 90.95% <100.00%> (ø)
Sources/ParseSwift/Objects/ParseUser.swift 93.48% <100.00%> (ø)

... and 6 files with indirect coverage changes

@cbaker6 cbaker6 changed the title refactor: Make some ParseObject methods and properties required refactor: Make some ParseObject methods required May 2, 2023
@cbaker6 cbaker6 merged commit 0e40929 into main May 2, 2023
27 of 28 checks passed
@cbaker6 cbaker6 deleted the addObjectReqs branch May 2, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant