feat: handle panic #254
Merged
feat: handle panic #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should then handle it not only for protobuf since it can panic e.g. with default json output. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds interceptor for decoder and producer that log potential panic for better debugging.
A line will contain a stacktrace if present
Example log line with JSON:
{ "blocking": false, "count": 1, "error": "receiver: test panic", "hostname": "", "level": "error", "message": { "Src": "[::ffff:127.0.0.1]:58224", "Dst": "[::]:6343", "Payload": "b64payload", "Received": "2023-12-09T03:57:33.928231Z" }, "msg": "intercepted panic", "port": 6343, "queue_size": 1000000, "scheme": "sflow", "stacktrace": "goroutine 49 [running]:\nruntime/debug.Stack()\n\t/usr/local/Cellar/go/1.21.0/libexec/src/runtime/debug/stack.go:24 +0x5e\nmain.main.PanicDecoderWrapper.func5.1()\n\t//goflow2/utils/debug/decoder.go:17 +0x71\npanic({0x1614ba0?, 0x1843c50?})\n\t/usr/local/Cellar/go/1.21.0/libexec/src/runtime/panic.go:914 +0x21f\ngithub.com/netsampler/goflow2/v2/decoders/sflow.DecodeMessage(0x16dc360?, 0xc000073ba0?)\n\t//goflow2/decoders/sflow/sflow.go:421 +0x25\ngithub.com/netsampler/goflow2/v2/decoders/sflow.DecodeMessageVersion(0x0?, 0xc0000a5900)\n\t//goflow2/decoders/sflow/sflow.go:417 +0x10e\ngithub.com/netsampler/goflow2/v2/utils.(*SFlowPipe).DecodeFlow(0xc000280480, {0x15fed80?, 0xc0001d10a0})\n\t//goflow2/utils/pipe.go:113 +0xe5\nmain.main.PanicDecoderWrapper.func5({0x15fed80?, 0xc0001d10a0?})\n\t//goflow2/utils/debug/decoder.go:20 +0x72\nmain.main.PromDecoderWrapper.func6({0x15fed80?, 0xc0001d10a0?})\n\t//goflow2/metrics/decoder.go:53 +0x63c\ngithub.com/netsampler/goflow2/v2/utils.(*UDPReceiver).decoders.func1()\n\t//goflow2/utils/udp.go:215 +0x249\ncreated by github.com/netsampler/goflow2/v2/utils.(*UDPReceiver).decoders in goroutine 1\n\t//goflow2/utils/udp.go:200 +0x32\n", "time": "2023-12-08T19:57:33-08:00", "workers": 2 }