Add TimeFlowStartMs and TimeFlowEndMs to Netflow v5, v9, v10 (IPFIX) #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
|
Thank you! |
vishnubraj
pushed a commit
to vishnubraj/goflow2
that referenced
this pull request
Oct 7, 2022
…w-start-end-ms Add TimeFlowStartMs and TimeFlowEndMs to Netflow v5, v9, v10 (IPFIX)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Action
Closes #78.
Description
In #78 was proposed to change the
TimeFlowStartandTimeFlowEndunits from seconds to milliseconds as it is specified both in RFC 3954 and NetFlow Version 9 Flow-Record Format for Netflow v9, which specifiedFIRST_SWITCHEDandLAST_SWITCHEDas System uptime in milliseconds. However as this would break many current implementations the fieldsTimeFlowStartMsandTimeFlowEndMshave been added to goflow2 for Netflow v5, v9 and v10 (IPFIX), as proposed in #78 and mentioned in #80.