Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[netcat] Create integration tests for netcat #63

Closed
N2D4 opened this issue Apr 24, 2019 · 1 comment
Closed

[netcat] Create integration tests for netcat #63

N2D4 opened this issue Apr 24, 2019 · 1 comment

Comments

@N2D4
Copy link
Contributor

N2D4 commented Apr 24, 2019

We initially intended to create integration tests for netcat, however due to issues with CI I've postponed it for now. My current (not working) code can be found here
@matzf
Copy link
Contributor

matzf commented May 27, 2020

Fixed by #149

@matzf matzf closed this as completed May 27, 2020
cneukom pushed a commit to cneukom/scion-apps that referenced this issue Nov 12, 2020
@ncw @lunny
Report errors to client when sending the RETR data (netsec-ethz#63)
eabccc5 
Before this change we ignored the errors returned from copying the
data to the socket.

This meant that if an error occurred the client would hang
indefinitely - the server thinking it had finished and the client
waiting for a response from the server.

After this change the server responds with a 551 message if the stream
breaks during the transfer.  This allows the client to pick up the
error and carry on.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@N2D4 @matzf