-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore segments to path graph & bug fixes #44
Conversation
- Adding path database lookup for segments - Using segments to derive core IAs in path graph - Prevent accidental db downgrade - Ensure localhost interface when not in VM - Default to port 8000, improved localhost defaults - Load default IA when not scionlab $SC not defined
- combine ia topology BRs using same ip:port - handle error case when src==dst - add filter for unused up, down, expired segments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 8 of 10 files at r1, 1 of 2 files at r2, 3 of 3 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default server addresses come from the addresses we encourage people to test scionlab apps with in our tutorials:
https://netsec-ethz.github.io/scion-tutorials/sample_projects/bwtester/
https://netsec-ethz.github.io/scion-tutorials/sample_projects/access_camera/
https://netsec-ethz.github.io/scion-tutorials/sample_projects/fetch_sensor_readings/
We use servers_default.json
to populate the server dropdown list on the webapp Apps
tab to make it easier to use out of the box..
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a suggestion to keep them out of the code base, I can add a future PR to migrate these locations to our Visualization GAE tool storing API keys. I probably need to move it anyway so that it moves from scion-viz
to scion-apps
.
Reviewable status: complete! all files reviewed, all discussions resolved
The major work of this PR is to restore segments to the path graph:
Additional minor fixes and improvements included:
This change is