Presenter::$onAfterSignal event

[mabar]

• new feature
• BC break? no

I am currently working on a Tracy panel which tracks submitted forms and shows errors from these forms.

This is useful for debugging manually rendered forms which don't render all form errors. e.g. datagrids

Problem is it is currently hooked via onStartup event. That works only for components that are created via createComponent*(), have all required parameters for creation available during startup and are not created manually - e.g. via $this['form'] = new Form(); in action*() method. It also changes order of code execution.

Having an onAfterSignal event would solve all of these issues and would also allow me to handle successfully submitted forms (which throw AbortException for redirect) and other signals

Current (bad) solution:

• https://github.com/orisai/nette-application/blob/bc394c43189e84f26f2f6efef2ff5de71414b7c5/src/FormMonitor/DI/FormMonitorExtension.php#L116-L122
• https://github.com/orisai/nette-application/blob/bc394c43189e84f26f2f6efef2ff5de71414b7c5/src/FormMonitor/SignalFormExtractor.php#L22

If you agree on proposed solution @dg I will write some tests for it.

[dg]

I think the catch can be omitted

[mabar]

It is used to assign Throwable to $signalException

[dg]

Remove it too. Just try ... finally

[dg]

Seem legit.

For consistency, it might be a good idea to add $onSignal too.