Cache::save() with closure is deprecated (BC break)

It was internal usage
nette · May 11, 2020 · 1b14a14 · 1b14a14
1 parent ae32ad9
commit 1b14a14
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/src/Caching/Cache.php b/src/Caching/Cache.php
@@ -168,6 +168,7 @@ public function save($key, $data, array $dependencies = null)
 		$key = $this->generateKey($key);
 
 		if ($data instanceof \Closure) {
+			trigger_error(__METHOD__ . '() closure argument is deprecated.', E_USER_WARNING);
 			$this->storage->lock($key);
 			try {
 				$data = $data(...[&$dependencies]);

diff --git a/tests/Caching/Cache.save.phpt b/tests/Caching/Cache.save.phpt
@@ -31,7 +31,7 @@ Assert::same($dependencies, $res['dependencies']);
 $storage = new testStorage;
 $cache = new Cache($storage, 'ns');
 
-$cache->save('key', function () {
+@$cache->save('key', function () { // @ deprecated
 	return 'value';
 });
 
@@ -45,7 +45,7 @@ $storage = new testStorage;
 $cache = new Cache($storage, 'ns');
 $dependencies = [Cache::TAGS => ['tag']];
 
-$cache->save('key', function () {
+@$cache->save('key', function () { // @ deprecated
 	return 'value';
 }, $dependencies);
 
@@ -59,7 +59,7 @@ $storage = new testStorage;
 $cache = new Cache($storage, 'ns');
 $dependencies = [Cache::EXPIRATION => new DateTime];
 
-$res = $cache->save('key', function () {
+@$res = $cache->save('key', function () { // @ deprecated
 	return 'value';
 }, $dependencies);
 Assert::same('value', $res);

diff --git a/tests/Storages/FileStorage.closure.phpt b/tests/Storages/FileStorage.closure.phpt
@@ -24,7 +24,7 @@ Assert::null($cache->load($key));
 
 
 // Writing cache using Closure...
-$res = $cache->save($key, function () use ($value) {
+$res = @$cache->save($key, function () use ($value) { // @ deprecated
 	return $value;
 });
 
@@ -34,7 +34,7 @@ Assert::same($cache->load($key), $value);
 
 
 // Removing from cache using null callback...
-$cache->save($key, function () {
+@$cache->save($key, function () { // @ deprecated
 	return null;
 });