-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More self-explaining message when constructor and factory parameters are mismatching #199
Comments
If you agree with this proposal, @grifart will send PR for this. |
jkuchar
changed the title
More useful error message when mismatching constructor and magic factory implementaion
More self-explaining message constructor and factory parameters are mismatching
May 10, 2019
jkuchar
changed the title
More self-explaining message constructor and factory parameters are mismatching
More self-explaining message when constructor and factory parameters are mismatching
May 10, 2019
👍 |
dakur
pushed a commit
to dakur/nette-di
that referenced
this issue
Jan 17, 2023
Here we go.. #284 |
dg
pushed a commit
that referenced
this issue
Jan 19, 2023
dg
pushed a commit
that referenced
this issue
Feb 27, 2023
dg
pushed a commit
that referenced
this issue
Feb 28, 2023
dg
pushed a commit
that referenced
this issue
Feb 28, 2023
dg
pushed a commit
that referenced
this issue
Mar 13, 2023
dg
pushed a commit
that referenced
this issue
Mar 13, 2023
dg
pushed a commit
that referenced
this issue
Mar 13, 2023
dg
pushed a commit
that referenced
this issue
Mar 14, 2023
dg
pushed a commit
that referenced
this issue
Mar 14, 2023
dg
pushed a commit
that referenced
this issue
Mar 23, 2023
dg
pushed a commit
that referenced
this issue
Jul 30, 2023
dg
pushed a commit
that referenced
this issue
Aug 5, 2023
dg
pushed a commit
that referenced
this issue
Aug 30, 2023
dg
pushed a commit
that referenced
this issue
Aug 30, 2023
dg
pushed a commit
that referenced
this issue
Aug 30, 2023
dg
pushed a commit
that referenced
this issue
Aug 30, 2023
dg
pushed a commit
that referenced
this issue
Sep 21, 2023
dg
pushed a commit
that referenced
this issue
Sep 21, 2023
dg
pushed a commit
that referenced
this issue
Sep 21, 2023
dg
pushed a commit
that referenced
this issue
Sep 22, 2023
dg
pushed a commit
that referenced
this issue
Sep 22, 2023
dg
added a commit
that referenced
this issue
Sep 28, 2023
dg
added a commit
that referenced
this issue
Sep 28, 2023
dg
added a commit
that referenced
this issue
Sep 28, 2023
dg
added a commit
that referenced
this issue
Sep 29, 2023
dg
added a commit
that referenced
this issue
Sep 29, 2023
dg
added a commit
that referenced
this issue
Sep 29, 2023
dg
added a commit
that referenced
this issue
Sep 29, 2023
dg
added a commit
that referenced
this issue
Sep 29, 2023
dg
added a commit
that referenced
this issue
Sep 29, 2023
dg
added a commit
that referenced
this issue
Sep 29, 2023
dg
added a commit
that referenced
this issue
Oct 2, 2023
dg
added a commit
that referenced
this issue
Oct 2, 2023
dg
added a commit
that referenced
this issue
Oct 15, 2023
dg
added a commit
that referenced
this issue
Oct 15, 2023
dg
added a commit
that referenced
this issue
Oct 15, 2023
dg
added a commit
that referenced
this issue
Oct 18, 2023
dg
added a commit
that referenced
this issue
Oct 18, 2023
dg
added a commit
that referenced
this issue
Oct 18, 2023
dg
added a commit
that referenced
this issue
Oct 18, 2023
dg
added a commit
that referenced
this issue
Oct 18, 2023
dg
added a commit
that referenced
this issue
Oct 18, 2023
dg
added a commit
that referenced
this issue
Oct 30, 2023
dg
added a commit
that referenced
this issue
Nov 2, 2023
dg
added a commit
that referenced
this issue
Nov 2, 2023
dg
added a commit
that referenced
this issue
Nov 2, 2023
dg
added a commit
that referenced
this issue
Nov 2, 2023
dg
added a commit
that referenced
this issue
Nov 2, 2023
dg
added a commit
that referenced
this issue
Nov 2, 2023
dg
added a commit
that referenced
this issue
Nov 2, 2023
dg
added a commit
that referenced
this issue
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I would like to propose more self-explanatory exception message for case when constructor and magic factory implementation does not match.
I found that it is not always clear that constructor and magic fatory are bind together using parameter names, not types. Which is logical from implementation perspective (no ambiguity), however counter-intuitive from user perspective.
originally implemented in #99
Proposal
Instead of saying just
I would say
Cannot implement ..\Components\HeaderFactory::create(), because parameters ($breadcrumbs, $logout) of factory method are not matching constructor of ...\Components\Breadrumbs ($breadcrumbsComponent, $logoutComponent).
The text was updated successfully, but these errors were encountered: