Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InjectExtension: Fix type hint and always executed if. #210

Merged
merged 1 commit into from Jul 19, 2019

Conversation

@janbarasek
Copy link
Contributor

janbarasek commented Jul 18, 2019

  • bug fix
  • BC break? no

Fix type error and if condition order:

 ------ ---------------------------------------------------------- 
  Line   DI/Extensions/InjectExtension.php                         
 ------ ---------------------------------------------------------- 
  37     Right side of && is always true.                          
  61     Parameter #4 $container of static method                  
         Nette\DI\Extensions\InjectExtension::checkType() expects  
         Nette\DI\Container|Nette\DI\Resolver|null,                
         Nette\DI\ContainerBuilder|null given.                     
 ------ ---------------------------------------------------------- 
@dg dg force-pushed the nette:master branch from 95d663e to 0768bda Jul 19, 2019
@dg dg merged commit edf67d2 into nette:master Jul 19, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.098%
Details
@dg

This comment has been minimized.

Copy link
Member

dg commented Jul 19, 2019

Thanks

dg added a commit that referenced this pull request Jul 19, 2019
dg added a commit that referenced this pull request Jul 19, 2019
dg added a commit that referenced this pull request Jul 19, 2019
dg added a commit that referenced this pull request Jul 19, 2019
dg added a commit that referenced this pull request Jul 19, 2019
dg added a commit that referenced this pull request Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.