Form: checks the existence of handlers

nette · Apr 7, 2021 · 842cb1e · 842cb1e
1 parent bfbef39
commit 842cb1e
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 0 deletions.
diff --git a/src/Forms/Form.php b/src/Forms/Form.php
@@ -410,7 +410,10 @@ public function fireEvents(): void
 			$this->validate();
 		}
 
+		$handled = count($this->onSuccess ?? []) || count($this->onSubmit ?? []);
+
 		if ($this->submittedBy instanceof Controls\SubmitButton) {
+			$handled = $handled || count($this->submittedBy->onClick ?? []);
 			if ($this->isValid()) {
 				$this->invokeHandlers($this->submittedBy->onClick, $this->submittedBy);
 			} else {
@@ -427,6 +430,10 @@ public function fireEvents(): void
 		}
 
 		Arrays::invoke($this->onSubmit, $this);
+
+		if (!$handled) {
+			trigger_error('Form was submitted but there are no associated handlers.', E_USER_WARNING);
+		}
 	}
 
 

diff --git a/tests/Forms/Controls.CsrfProtection.phpt b/tests/Forms/Controls.CsrfProtection.phpt
@@ -22,6 +22,7 @@ $form = new Form;
 
 $input = $form->addProtection('Security token did not match. Possible CSRF attack.');
 
+$form->onSuccess[] = function () {};
 $form->fireEvents();
 
 Assert::same(['This field is required.'], $form->getErrors());

diff --git a/tests/Forms/Controls.SelectBox.isOk.phpt b/tests/Forms/Controls.SelectBox.isOk.phpt
@@ -48,5 +48,6 @@ Form::initialize(true);
 Validator::$messages[Nette\Forms\Controls\SelectBox::VALID] = 'SelectBox "%label" must be filled.';
 $form = new Form;
 $form->addSelect('foo', 'Foo', ['bar' => 'Bar']);
+$form->onSuccess[] = function () {};
 $form->fireEvents();
 Assert::same(['SelectBox "Foo" must be filled.'], $form->getErrors());
diff --git a/tests/Forms/Forms.isValid.phpt b/tests/Forms/Forms.isValid.phpt
@@ -93,6 +93,7 @@ test('', function () {
 
 	$form->addError('1');
 	$form['item']->addError('2');
+	$form->onSuccess[] = function () {};
 	$form->fireEvents();
 
 	Assert::true($form->isSubmitted());

diff --git a/tests/Forms/Forms.renderer.1.phpt b/tests/Forms/Forms.renderer.1.phpt
@@ -124,6 +124,7 @@ $defaults = [
 ];
 
 $form->setDefaults($defaults);
+$form->onSuccess[] = function () {};
 $form->fireEvents();
 
 Assert::matchFile(__DIR__ . '/Forms.renderer.1.expect', $form->__toString(true));
diff --git a/tests/Forms/Forms.renderer.2.phpt b/tests/Forms/Forms.renderer.2.phpt
@@ -129,6 +129,7 @@ $defaults = [
 ];
 
 $form->setDefaults($defaults);
+$form->onSuccess[] = function () {};
 $form->fireEvents();
 
 Assert::matchFile(__DIR__ . '/Forms.renderer.2.expect', $form->__toString(true));
diff --git a/tests/Forms/Forms.renderer.3.phpt b/tests/Forms/Forms.renderer.3.phpt
@@ -18,6 +18,7 @@ $form = new Nette\Forms\Form;
 $form->addHidden('userid');
 $form->addSubmit('submit', 'Send');
 
+$form->onSuccess[] = function () {};
 $form->fireEvents();
 
 Assert::match('<form action="" method="post">