New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fluent setter and getter for checkAllowedValues #151
Conversation
|
any suggestion? I mean variable name is checkAllowedValues, so I just added set before... |
How about |
Sounds good. Although it sounds that values are checked by calling that method. |
|
Better now? |
@PavelJurasek I think about the same, but with parameter name |
8ed13d7
to
d6aa86e
Compare
1c0b101
to
2e462fb
Compare
Sorry for not following template, but I believe everything is preety clear here.
I run into this one on project I'm working on and IMHO checkAllowedValues shouldn't be just field but property with fluent setter. It's also more consistent like that and easier to add.
I wished to set it as private as well but that would be breaking change...