Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SmtpSender: Better handling of exceptions thrown when building the message #43

Merged
merged 1 commit into from Jul 23, 2017

Conversation

@Andrewsville
Copy link
Contributor

Andrewsville commented Jul 23, 2017

  • bug fix? yes, #42
  • new feature? no
  • BC break? no

Message contents are built before the communication with the SMTP server is started. In case an exception is thrown during message building, the connection is left in sane state. More in #42

@dg

This comment has been minimized.

Copy link
Member

dg commented Jul 23, 2017

Thanks

@dg dg merged commit 2246d47 into nette:master Jul 23, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 71.111%
Details
dg added a commit that referenced this pull request Jul 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.