Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddConstant does not validate name. #24

Closed
SamMousa opened this issue Feb 9, 2017 · 1 comment
Closed

AddConstant does not validate name. #24

SamMousa opened this issue Feb 9, 2017 · 1 comment

Comments

@SamMousa
Copy link

@SamMousa SamMousa commented Feb 9, 2017

  • bug report? yes
  • feature request?no
  • version: v2.5.x-dev

Description

Constant names are not validated resulting in invalid PHP files.

Steps To Reproduce

$file = new \Nette\PhpGenerator\PhpFile();
$object = $file->addClass('Tester');
$object->addConstant('test-invalid-name', "value");
dg added a commit that referenced this issue Feb 22, 2017
dg added a commit that referenced this issue Feb 22, 2017
@dg

This comment has been minimized.

Copy link
Member

@dg dg commented Feb 22, 2017

Fixed

@dg dg closed this Feb 22, 2017
dg added a commit that referenced this issue Feb 22, 2017
dg added a commit that referenced this issue Feb 22, 2017
dg added a commit that referenced this issue Feb 22, 2017
dg added a commit that referenced this issue Feb 23, 2017
dg added a commit that referenced this issue Feb 23, 2017
dg added a commit that referenced this issue Feb 23, 2017
dg added a commit that referenced this issue Feb 23, 2017
dg added a commit that referenced this issue Feb 23, 2017
dg added a commit that referenced this issue Feb 23, 2017
dg added a commit that referenced this issue Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.