Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluescreen cannot render when magic `__isset` on rendered exception throws another exception #305

Closed
kukulich opened this issue May 26, 2018 · 0 comments

Comments

@kukulich
Copy link
Contributor

@kukulich kukulich commented May 26, 2018

Version: 2.5.0

Bug Description

Bluescreen cannot render when magic __isset on rendered exception throws another exception.

The problematic code is:

if (!empty($ex->tracyAction['link']) && !empty($ex->tracyAction['label'])) {
	$actions[] = $ex->tracyAction;
}

Steps To Reproduce

Try to render this exception:

class FooException extends Exception
{
	public function __isset($name)
	{
                throw new Exception('Isset is disabled');
	}    
}

Possible Solution

There should be an interface to detect exceptions with actions.

@dg dg closed this in be9d8c6 May 27, 2018
dg added a commit that referenced this issue May 28, 2018
dg added a commit that referenced this issue May 28, 2018
kukulich added a commit to slevomat/tracy that referenced this issue May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.