Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding of custom icons to panel header. By being explicit about what the "window" icon does, we can add others without them triggering this action. #276

Merged
merged 2 commits into from Mar 22, 2018

Conversation

@adrianbj
Copy link
Contributor

adrianbj commented Dec 22, 2017

No description provided.

adrianbj added 2 commits Dec 22, 2017
… what the "window" icon does, we can add others without them triggering this action.
@dg dg force-pushed the nette:master branch 4 times, most recently from d13a9ce to 7f24887 Feb 25, 2018
@dg dg force-pushed the nette:master branch from 865ff2a to 25c8769 Mar 22, 2018
@adrianbj

This comment has been minimized.

Copy link
Contributor Author

adrianbj commented Mar 22, 2018

Hey @dg - is there any reason not to include this? I have been running it for several months now and it works fine and really helps out - it lets other add other icons to the panels - in my case I added "large window" and "small window" icons so it's easy to expand / contract the panel as needed.

@dg

This comment has been minimized.

Copy link
Member

dg commented Mar 22, 2018

I just overlooked it.

@dg dg merged commit 84f062f into nette:master Mar 22, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@adrianbj

This comment has been minimized.

Copy link
Contributor Author

adrianbj commented Mar 22, 2018

Thanks very much!

@dg

This comment has been minimized.

Copy link
Member

dg commented Mar 22, 2018

Thanks for PR :)

dg added a commit that referenced this pull request Mar 22, 2018
…about what the "window" icon does, we can add others without them triggering this action. (#276)
dg added a commit that referenced this pull request Mar 23, 2018
…about what the "window" icon does, we can add others without them triggering this action. (#276)
dg added a commit that referenced this pull request Mar 23, 2018
…about what the "window" icon does, we can add others without them triggering this action. (#276)
dg added a commit that referenced this pull request Mar 23, 2018
…about what the "window" icon does, we can add others without them triggering this action. (#276)
dg added a commit that referenced this pull request Mar 23, 2018
…about what the "window" icon does, we can add others without them triggering this action. (#276)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.