Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding of custom icons to panel header. By being explicit about what the "window" icon does, we can add others without them triggering this action. #276

Merged
merged 2 commits into from Mar 22, 2018

Conversation

adrianbj
Copy link
Contributor

@adrianbj adrianbj commented Dec 22, 2017

No description provided.

adrianbj added 2 commits Dec 22, 2017
… what the "window" icon does, we can add others without them triggering this action.
@adrianbj
Copy link
Contributor Author

@adrianbj adrianbj commented Mar 22, 2018

Hey @dg - is there any reason not to include this? I have been running it for several months now and it works fine and really helps out - it lets other add other icons to the panels - in my case I added "large window" and "small window" icons so it's easy to expand / contract the panel as needed.

@dg
Copy link
Member

@dg dg commented Mar 22, 2018

I just overlooked it.

@dg dg merged commit 84f062f into nette:master Mar 22, 2018
0 of 2 checks passed
@adrianbj
Copy link
Contributor Author

@adrianbj adrianbj commented Mar 22, 2018

Thanks very much!

@dg
Copy link
Member

@dg dg commented Mar 22, 2018

Thanks for PR :)

dg pushed a commit that referenced this issue Mar 22, 2018
…about what the "window" icon does, we can add others without them triggering this action. (#276)
dg pushed a commit that referenced this issue Mar 23, 2018
…about what the "window" icon does, we can add others without them triggering this action. (#276)
dg pushed a commit that referenced this issue Mar 23, 2018
…about what the "window" icon does, we can add others without them triggering this action. (#276)
dg pushed a commit that referenced this issue Mar 23, 2018
…about what the "window" icon does, we can add others without them triggering this action. (#276)
dg pushed a commit that referenced this issue Mar 23, 2018
…about what the "window" icon does, we can add others without them triggering this action. (#276)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants