Image: add support for webp #73
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -101,7 +101,8 @@ class Image extends Nette\Object | |||
| /** image types */ | |||
| const JPEG = IMAGETYPE_JPEG, | |||
| PNG = IMAGETYPE_PNG, | |||
| GIF = IMAGETYPE_GIF; | |||
| GIF = IMAGETYPE_GIF, | |||
| WEBP = -1; | |||
There was a problem hiding this comment.
Similar constant for webp does not exist (yet).
|
Does getimagesizefromstring support WEBP? |
|
Oh boy of course it does not. :-( |
|
There is no way to detect webp images in fromString and fromFile (aside from checking file extension in fromFile) so I removed webp from both. But I still think Nette\Utils\Image should be able to generate webp images. |
|
It is possible via |
|
Ok, closing for now. Thank you. |
|
Webp support has been added for PHP 7.1RC4. It should be possible to implement this now. |
dg
added a commit
that referenced
this pull request
Dec 19, 2016
dg
added a commit
that referenced
this pull request
Dec 19, 2016
dg
added a commit
that referenced
this pull request
Dec 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how to write tests - there aren't any tests specific for the other types either.
Also should I check for php version?