Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

n-dhcp4-client: check broadcast_mac field in n_dhcp4_client_config_set_broadcast_mac() #36

Closed
wants to merge 1 commit into from

Conversation

thom311
Copy link
Contributor

@thom311 thom311 commented Aug 10, 2022

Since the "mac" and "broadcast_mac" fields have the same size, there
was no actual bug here. Still, it feels more correct.


[trivial]

…t_broadcast_mac()

Since the "mac" and "broadcast_mac" fields have the same size, there
was no actual bug here. Still, it feels more correct.
Copy link
Member

@dvdhrm dvdhrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

thom311 added a commit that referenced this pull request Aug 11, 2022
…t_broadcast_mac()

Since the "mac" and "broadcast_mac" fields have the same size, there
was no actual bug here. Still, it feels more correct.

#36
@thom311
Copy link
Contributor Author

thom311 commented Aug 11, 2022

merged. Thanks!

@thom311 thom311 closed this Aug 11, 2022
@thom311 thom311 deleted the th/set-broadcast-mac branch May 4, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants