Skip to content

Commit

Permalink
[#3945] Http2ConnectionHandler breaks channelReadComplete pipeline no…
Browse files Browse the repository at this point in the history
…tification

Motivation:

Http2ConnectionHandler missed to forward channelReadComplete(...) events.

Modifications:

Ensure we notify the next handler in the pipeline via ctx.fireChannelReadComplete().

Result:

Correctly forwarding of event.
  • Loading branch information
normanmaurer committed Jul 7, 2015
1 parent 0f95b85 commit 9760922
Showing 1 changed file with 5 additions and 1 deletion.
Expand Up @@ -455,7 +455,11 @@ public void write(ChannelHandlerContext ctx, Object msg, ChannelPromise promise)
public void channelReadComplete(ChannelHandlerContext ctx) throws Exception {
// Trigger flush after read on the assumption that flush is cheap if there is nothing to write and that
// for flow-control the read may release window that causes data to be written that can now be flushed.
flush(ctx);
try {
flush(ctx);
} finally {
super.channelReadComplete(ctx);
}
}

/**
Expand Down

0 comments on commit 9760922

Please sign in to comment.