Skip to content

Commit

Permalink
netty-dev-tools use wrong parent pom (#13798)
Browse files Browse the repository at this point in the history
Motivation:

netty-dev-tools used the wrong parent pom and so did not include all the
license infos etc.

Modifications:

Declare the correct parent pom

Result:

Fixes #13787
  • Loading branch information
normanmaurer committed Jan 22, 2024
1 parent 4eb174d commit dee995e
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 16 deletions.
1 change: 1 addition & 0 deletions common/pom.xml
Expand Up @@ -69,6 +69,7 @@
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty5-dev-tools</artifactId>
<version>${project.version}</version>
<scope>test</scope>
<optional>true</optional>
</dependency>
Expand Down
12 changes: 4 additions & 8 deletions dev-tools/pom.xml
Expand Up @@ -17,17 +17,13 @@
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/maven-v4_0_0.xsd">
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>org.sonatype.oss</groupId>
<artifactId>oss-parent</artifactId>
<version>7</version>
<relativePath />
<groupId>io.netty</groupId>
<artifactId>netty5-parent</artifactId>
<version>5.0.0.Alpha6-SNAPSHOT</version>
</parent>

<groupId>io.netty</groupId>
<artifactId>netty5-dev-tools</artifactId>
<version>5.0.0.Alpha6-SNAPSHOT</version>

<name>Netty5/Dev-Tools</name>
<name>Netty/Dev-Tools</name>

<build>
<plugins>
Expand Down
10 changes: 2 additions & 8 deletions pom.xml
Expand Up @@ -642,12 +642,6 @@
<optional>true</optional>
</dependency>

<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>netty5-dev-tools</artifactId>
<version>${project.version}</version>
</dependency>

<!-- Needed for java11 and later as javax.activation is not part of the JDK anymore -->
<dependency>
<groupId>com.sun.activation</groupId>
Expand Down Expand Up @@ -1760,7 +1754,7 @@
<!-- bundledSignature>jdk-system-out</bundledSignature -->
</bundledSignatures>
<signaturesFiles>
<signaturesFile>${netty.dev.tools.directory}/forbidden/signatures.txt</signaturesFile>
<signaturesFile>../target/dev-tools/forbidden/signatures.txt</signaturesFile>
</signaturesFiles>
<suppressAnnotations><annotation>**.SuppressForbidden</annotation></suppressAnnotations>
</configuration>
Expand All @@ -1784,7 +1778,7 @@
<!-- bundledSignature>jdk-deprecated</bundledSignature -->
</bundledSignatures>
<signaturesFiles>
<signaturesFile>${netty.dev.tools.directory}/forbidden/signatures.txt</signaturesFile>
<signaturesFile>../target/dev-tools/forbidden/signatures.txt</signaturesFile>
</signaturesFiles>
<suppressAnnotations><annotation>**.SuppressForbidden</annotation></suppressAnnotations>
</configuration>
Expand Down

0 comments on commit dee995e

Please sign in to comment.